AutoValue #491
Closed
AutoValue #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@cammace Please let me know once CI is happy and I'll give this one a pass. |
Author
|
I'm going to go ahead and close this PR in favor of a new one which moves logic over to AutoValue. This PR was more of an experiment to learn about the cost and benefits of using AutoValue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into the AutoValue suggestion in #450, I successfully converted two model classes to see how this would work. There are going to be significant API breaking changes if we want to fully implement this. I also didn't mess around with adding Builders for each class since you can call
create()passing in all the params and receive a built object.Using AutoValues also enforces classes to be immutable which makes sense for these models, you can currently call
setRouteat any time after constructed.Would love to hear your thoughts on this @zugaldia