Several geocoding fixes and additions #512
Conversation
zugaldia
left a comment
zugaldia
left a comment
There was a problem hiding this comment.
A few questions, otherwise we're very close.
| autocomplete.setAccessToken(Utils.getMapboxAccessToken(this)); | ||
| autocomplete.setType(GeocodingCriteria.TYPE_POI); | ||
| autocomplete.setLimit(10); | ||
| autocomplete.setLanguages(Locale.JAPAN.toString()); |
There was a problem hiding this comment.
@cammace did you intend to leave Japan's locale here?
| builder = new MapboxGeocoding.Builder(); | ||
| builder = new MapboxGeocoding.Builder<>(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why was this change necessary? It looks like a change on our standard builder approach.
There was a problem hiding this comment.
Was receiving a lint warning unchecked assignment so I added the <> which seemed to make it happy. Can switch back if there's an issue?
There was a problem hiding this comment.
Oh that's alright, I just wanted to make sure new MapboxGeocoding.Builder(); still was an option.
| private String matchingText; | ||
| @SerializedName("matching_place_name") | ||
| private String matchingPlaceName; | ||
| private String language; |
There was a problem hiding this comment.
Maybe I missed them but I can't seem to find tests for these new fields.
There was a problem hiding this comment.
👍 The methods are now being tested.
| * @since 1.0.0 | ||
| */ | ||
| public class GeocoderAutoCompleteView extends AutoCompleteTextView { | ||
| public class GeocoderAutoCompleteView extends android.support.v7.widget.AppCompatAutoCompleteTextView { |
|
Ready for another review @zugaldia |
2 participants
This PR:
GeocoderAdapter.javato non-public since user has no reason for usingTYPE_DISTRICTandTYPE_LOCALITYresult filters addedplace_typesupport in Carman Featurematching_textsupport in Carman Featurematching_place_namesupport in Carman Featurelanguagesupport in Carman FeatureI haven't added support for
text_{language},place_name_{language}and language_{language} since the field name depends on different languages. These are rarely used in the geocoder however so it might be better just to ticket out if it is too much work implementing before 2.2.0 release.