Add Abbreviations and type to BannerComponent #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
approved these changes
Mar 21, 2018
osana
approved these changes
Mar 22, 2018
Contributor
osana
left a comment
osana
left a comment
There was a problem hiding this comment.
make sure checkstyle passes
seems that some of the lines are long
./gradlew checkstyleMain
danesfeder
force-pushed
the
dan-add-abbr
branch
from
362af08 to
9b5496a
Compare
Contributor
Author
|
💯 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added recently for banner instruction work to be consumed by the navigation SDK.
cc @devotaaabel @Guardiola31337