Implemented Comparable in BannerComponents #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devotaaabel
requested review from
Guardiola31337,
cammace,
danesfeder and
osana
osana
reviewed
Mar 26, 2018
| */ | ||
| @Override | ||
| public int compareTo(BannerComponents bannerComponents) { | ||
| return this.abbreviationPriority().compareTo(bannerComponents.abbreviationPriority()); |
Contributor
There was a problem hiding this comment.
Looks like abbreviationPriority is Nullable, so null check should be there
added 4 commits
March 27, 2018 20:57
Contributor
Author
|
@osana ready to re-review |
osana
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Comparable in BannerComponents so that they can be sorted/compared by abbreviation priority.