Pass error responses for Mapbox Directions and MapMatching #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
force-pushed
the
dan-error-scenario
branch
from
11ca7ec to
59c786d
Compare
Guardiola31337
approved these changes
Feb 12, 2019
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Great work removing the unnecessary wrapper for the "unsuccessful responses" and cleaning up the code / extracting Directions and Map Matching response factories 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently checking / passing error responses to
Callback#onFailure. From the Retrofit javadoc >Callback#onFailure:Technically, when we receive an error code (
DirectionsError) from either the Directions or MapMatching API, this scenario is not occurring so we shouldn't force the error message toonFailurewrapped in aThrowable.