Fixing banner MAS models to match what actually comes from Directions API #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langsmith
force-pushed
the
ls-fix-banner-MAS-models-to-match-directions
branch
from
d9fdacc to
db0eae9
Compare
langsmith
force-pushed
the
ls-fix-banner-MAS-models-to-match-directions
branch
from
db0eae9 to
efa6ea0
Compare
Contributor
|
👍 I am guessing once tests are fixed that would be good to go |
Author
Yea, had to fix one test |
osana
approved these changes
Apr 9, 2019
| .primary(BannerText.builder().build()) | ||
| .secondary(BannerText.builder().build()) | ||
| .primary(BannerText.builder().text("Banner primary sample text").build()) | ||
| .secondary(BannerText.builder().text("Banner secondary sample text").build()) |
Contributor
There was a problem hiding this comment.
If secondary is @Nullable, this is not needed right? I mean, passing a null value (as before) should work too.
Author
There was a problem hiding this comment.
Thanks for checking in @Guardiola31337 . Looks like null is fine as a parameter.
Contributor
There was a problem hiding this comment.
Yeah and we'd be implicitly "testing" that secondary could be @Nullable, thanks for confirming @langsmith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #951 by adjusting the several annotations which @Guardiola31337 listed in #951.
@osana , I don't believe there are any other downstream changes that need to happen based on these annotation updates, but if so, please let me know.