Skip to content

Conversation

@osana
Copy link
Contributor

@osana osana commented Apr 11, 2019

Mapbox java sdk uses AutoValue library to generate boilerplate code for value setters / getters and to generate equals, hashCode and toString methods.

It is a useful tool. However, it was reported that generated .java files end up in the library jars. This is undersirable. This PR excludes .java files from being added to the library jars.

closes #989

@osana osana requested review from LukasPaczos and tobrun April 11, 2019 01:35
@osana osana force-pushed the osana-remove-from-jar branch from ad62f4e to 0a4d1f8 Compare April 11, 2019 01:36
@osana
Copy link
Contributor Author

osana commented Apr 11, 2019

An easy way to check that there are no java classes is to list jar content.

jar tf services-directions/build/libs/services-directions-4.6.0-SNAPSHOT.jar

@osana osana merged commit be2f75c into master Apr 11, 2019
@osana osana deleted the osana-remove-from-jar branch April 11, 2019 13:32
@osana osana mentioned this pull request Apr 11, 2019
16 tasks
@osana osana self-assigned this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude AutoValue java files from jar

2 participants