[style] validate fully loaded event of style #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-style-load
branch
2 times, most recently
from
2e099db to
5d24690
Compare
kiryldz
reviewed
May 19, 2021
| handlerMain.post { | ||
| nativeMapWeakRef.call { (this as StyleManagerInterface).styleURI = styleUri } | ||
| } | ||
| nativeMapWeakRef.call { (this as StyleManagerInterface).styleURI = styleUri } |
Contributor
There was a problem hiding this comment.
A bit concerned here.
We're removing handler logic here but leaving it in sdk/src/main/java/com/mapbox/maps/NativeObserver.kt. If I remember correctly some some metrics benchmarks were having a deadlock because of not posting here.
Contributor
There was a problem hiding this comment.
If tests pass - we can follow up later.
Member
Author
There was a problem hiding this comment.
agreed, let me dig up why we have that construct
kiryldz
approved these changes
May 19, 2021
Contributor
kiryldz
left a comment
kiryldz
left a comment
There was a problem hiding this comment.
LGTM but better check metrics before merging.
tobrun
force-pushed
the
tvn-style-load
branch
6 times, most recently
from
fb46aa8 to
87f98ee
Compare
|
|
tobrun
force-pushed
the
tvn-style-load
branch
2 times, most recently
from
c5819e8 to
d8fdd31
Compare
Member
Author
|
RC.3 tag landed, going to merge to be included in RC.4 |
7 tasks
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
mapbox-maps-androidchangelog:<changelog></changelog>.Summary of changes
We currently maintain style loaded state in the SDK to workaround an upstream issue.
This PR validates if we can remove that state checking from our end.