Public interface camera api#944
Merged
maios merged 9 commits intorepo-structure-multi-pluginsfrom May 16, 2025
Merged
Conversation
evil159
reviewed
May 16, 2025
| import 'package:flutter_test/flutter_test.dart'; | ||
| import 'package:integration_test/integration_test.dart'; | ||
| import 'package:mapbox_maps_flutter/mapbox_maps_flutter.dart'; | ||
| import 'package:mapbox_maps_flutter_interface/mapbox_maps_flutter_interface.dart' |
Contributor
There was a problem hiding this comment.
Not sure if this is the way to go - the examples need to import the public package not the internal one.
| @override | ||
| Future<void> setCamera(CameraOptions cameraOptions) { | ||
| if (cameraOptions.center != null) { | ||
| cameraOptions.center = Point._from(cameraOptions.center!); |
Contributor
There was a problem hiding this comment.
Why does this have to be re-assigned?
Contributor
Author
There was a problem hiding this comment.
initially I left the part where we extend turf's Point in mobile package, that's why I had to cast type here so the Codec would understand, otherwise it would throw an error Invalid type. But now I moved those extensions to interface package and removed this cast
evil159
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
ScreenCoordinate,MbxEdgeInsets,CameraOptionsandCameraStatetomapbox_maps_flutter_interfaceWhat is the motivation and context behind this change?
Pull request checklist:
PRs must be submitted under the terms of our Contributor License Agreement CLA.