[gestures] Add option to avoid waiting for the single tap to fail when double-tapping to zoom#2419
Open
nkartashov wants to merge 2 commits intomapbox:mainfrom
Open
[gestures] Add option to avoid waiting for the single tap to fail when double-tapping to zoom#2419nkartashov wants to merge 2 commits intomapbox:mainfrom
nkartashov wants to merge 2 commits intomapbox:mainfrom
Conversation
bd812f4 to
3eae0c7
Compare
3eae0c7 to
d489915
Compare
Author
|
@persidskiy could you take a look and give feedback on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/why
There is an issue in the app called Boolder where the double-tap to zoom was disabled because after the changes in the SDK the double-tap started requiring a single tap to fail which introduced a delay and resulted in bad UX. This change adds an option to revert back to the old behavior. The option does not do anything by default.
Fixes: #1560
Pull request checklist:
## mainheading near the top).v10.[version]release branch fix / enhancement, merge it tomainfirst and then port tov10.[version]release branch.PRs must be submitted under the terms of our Contributor License Agreement CLA.