Skip to content

[gestures] Add option to avoid waiting for the single tap to fail when double-tapping to zoom#2419

Open
nkartashov wants to merge 2 commits intomapbox:mainfrom
nkartashov:double-tap-without-fail-option
Open

[gestures] Add option to avoid waiting for the single tap to fail when double-tapping to zoom#2419
nkartashov wants to merge 2 commits intomapbox:mainfrom
nkartashov:double-tap-without-fail-option

Conversation

@nkartashov
Copy link
Copy Markdown

What/why

There is an issue in the app called Boolder where the double-tap to zoom was disabled because after the changes in the SDK the double-tap started requiring a single tap to fail which introduced a delay and resulted in bad UX. This change adds an option to revert back to the old behavior. The option does not do anything by default.

Fixes: #1560

Pull request checklist:

  • Describe the changes in this PR, especially public API changes.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. Put tests in correct Test Plan (Unit, Integration, All)
    • If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.
  • Add any new public, top-level symbols to the DocC custom catatlog (Sources/MapboxMaps/Documentation.docc/API Catalogs)
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • Update the guides (internal access only), README.md, and DEVELOPING.md if their contents are impacted by these changes.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main first and then port to v10.[version] release branch.

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@nkartashov nkartashov requested a review from a team as a code owner April 20, 2026 20:29
@nkartashov nkartashov requested a review from persidskiy April 20, 2026 20:29
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 20, 2026

CLA assistant check
All committers have signed the CLA.

@nkartashov nkartashov force-pushed the double-tap-without-fail-option branch from bd812f4 to 3eae0c7 Compare April 20, 2026 20:33
@nkartashov nkartashov force-pushed the double-tap-without-fail-option branch from 3eae0c7 to d489915 Compare April 25, 2026 21:11
@nkartashov
Copy link
Copy Markdown
Author

@persidskiy could you take a look and give feedback on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow clients to conditionally set the failure dependency between the single and double tap gestures

2 participants