NullPointerException when when route built with MapboxDirections.builder()

[riastrad]

Android API:
Mapbox Navigation SDK version: 0.12.0

Steps to trigger behavior

1. Create a route using MapboxDirections.builder() instead of NavigationRoute.builder()
2. Add a few waypoints using .addWaypoint()
3. Start turn-by-turn navigation

Expected behavior

Turn-by-turn navigation should progress normally without any issues.

Actual behavior

A NullPointerException is thrown when the first way point is encountered

Error log:

java.lang.NullPointerException: Attempt to invoke interface method 'java.util.Iterator java.util.List.iterator()' on a null object reference 
at com.mapbox.services.android.navigation.v5.milestone.BannerInstructionMilestone.isOccurring(BannerInstructionMilestone.java:29) 
at com.mapbox.services.android.navigation.v5.navigation.NavigationHelper.checkMilestones(NavigationHelper.java:201) 
at com.mapbox.services.android.navigation.v5.navigation.NavigationEngine.handleRequest(NavigationEngine.java:76) 
at com.mapbox.services.android.navigation.v5.navigation.NavigationEngine.handleMessage(NavigationEngine.java:41) 
at android.os.Handler.dispatchMessage(Handler.java:101) 
at android.os.Looper.loop(Looper.java:164) 
at android.os.HandlerThread.run(HandlerThread.java:65) 

[danesfeder]

Hey @riastrad, thanks for opening this - the Nav SDK version you referenced looks like the Maps SDK. Our latest version is 0.13.0, is this the version you were producing this with? Thanks!

[riastrad]

@danesfeder, my mistake. Looks like I misread the original ticket. 0.13.0 should be the correct version.

[danesfeder]

@riastrad no problem, do you by chance have the route request code that reproduces this? I'm trying to configure a way to reproduce but can't seem to do so - thanks!

[riastrad]

Sure thing, @danesfeder. Here's the the class that generated the route that would cause the error:

RouteGeneratorRequest.java.zip

[danesfeder]

@riastrad let's maybe pair on this tomorrow after ☕️ ? I'm missing some classes from your java code so it would be easier to see on your computer. Opening up a work-in-progress PR in the meantime. Thanks!

[danesfeder]

@riastrad please keep us posted on the findings regarding this issue, thanks!

[riastrad]

Sure thing, @danesfeder. It turns out the initial NPE was thrown using SDK version 0.12.0. I've asked the user to update to 0.13.0 and report back if the problem persists. Will let you know the moment I hear back from them.

[danesfeder]

Closing this for now - waiting on response from original developer who submitted the issue. Will reopen if needed. Thanks @riastrad!