-
Notifications
You must be signed in to change notification settings - Fork 319
Camera tracking modes selection with GPS and North as options #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
38f8f9c to
902be28
Compare
danesfeder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasPaczos this looks great! One minor comment to check before we merge, but I think we are in the clear regarding it.
| return; //no need to recalculate these values | ||
| } | ||
| initialRoute = route; | ||
| routeCoordinates = generateRouteCoordinates(route); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasPaczos can we double check that these routeCoordinates are still being used? I believe they are (for the route overview LatLngBounds) but just want to double check - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they are being used for the overview as you mentioned :)
|
@LukasPaczos @danesfeder The only way we managed to solve this was to remove the |
|
@hurrba are you adjusting with the You should be able to set the tracking mode with this PR and at the same time use We could do this for you when you set the tracking mode, but that would couple the padding adjustment and other developers may not desire this same behavior. |
|
@danesfeder that seems to do the trick! |
Will be for sure! Thanks for the suggestion and for checking out the SDK! |
902be28 to
9c2b954
Compare
9c2b954 to
dfbf812
Compare
|
@LukasPaczos @danesfeder @Guardiola31337 my original comment is still relevant if using this when showing wayname. see #1465 |
Added
NAVIGATION_TRACKING_MODE_GPSandNAVIGATION_TRACKING_MODE_NORTHas camera tracking options that can be set viaNavigationMapboxMap#updateCameraTrackingMode.Code used for the example:
and