Add OnCameraTrackingChangedListener to NavigationMapboxMap #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
✓ ready for review
feature
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
This is an awesome addition!
Other than 👇 minor comment, this look good to me 🚀 Thanks @danesfeder 🙇
|
|
||
| import com.mapbox.mapboxsdk.plugins.locationlayer.OnCameraTrackingChangedListener; | ||
|
|
||
| public class NavigationOnCameraTrackingChangedListener implements OnCameraTrackingChangedListener { |
Contributor
There was a problem hiding this comment.
Let's add javadoc for this new class.
Contributor
Author
There was a problem hiding this comment.
👀 the constructor is not public so wasn't sure - added regardless
Contributor
There was a problem hiding this comment.
@danesfeder
Ohh didn't 👀 In that case, I guess the public modifier is not needed, right?
LukasPaczos
approved these changes
Oct 3, 2018
LukasPaczos
left a comment
LukasPaczos
left a comment
There was a problem hiding this comment.
LGTM, thanks for running with that @danesfeder!
danesfeder
force-pushed
the
dan-tracking-listener
branch
from
72bbbe4 to
ad26642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #366
This work was added by @LukasPaczos in the
LocationLayerPlugina while ago and with his work on Monday to port over the LLP camera, it's unlocked. Users can now interact with theMapboxMapinNavigationViewwithout the camera being dismissed right away.Maintaining tracking while adjusting zoom:
Dismissal still fires with more aggressive interaction: