Add tunnels functionality

[Guardiola31337]

Fixes #835

• Adds tunnels functionality
  • Adds a new option (TunnelListener) to NavigationViewOptions
    • Should we expose new APIs in MapboxNavigation for adding / removing this listener? Or even remove this listener altogether? Currently it's possible to get the same inTunnel information attaching to ProgressChangeListener and querying the RouteProgress 👀

      mapbox-navigation-android/app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/RerouteActivity.java

      Line 218 in 9c8d687

      boolean inTunnel = routeProgress.inTunnel();

      Is this adding a duplicated behavior or making the API more friendly? Thoughts @danesfeder @devotaaabel? 👉 Add tunnels functionality #1392 (comment)
  • The SDK doesn't change day-night mode automatically anymore. Clients should be responsible of this moving forward. We 👀 if isNightModeEnabled and set the theme accordingly though. Kinda revert Use theme attribute to update MapView map style URL #1018
  • Adds day-night mode (UI) switching when entering / exiting a tunnel to some examples from the test app in order to showcase how to implement that behavior from a client point of view

TODOs

• Noticed that in the EmbeddedNavigationActivity and FragmentNavigationActivity examples from the test app voice instructions are "duplicated" after recreating the Activity

[Guardiola31337]

• Adds a new option (TunnelListener) to NavigationViewOptions
  • Should we expose new APIs in MapboxNavigation for adding / removing this listener? Or even remove this listener altogether? Currently it's possible to get the same inTunnel information attaching to ProgressChangeListener and querying the RouteProgress 👀

    mapbox-navigation-android/app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/RerouteActivity.java

    Line 218 in 9c8d687

    boolean inTunnel = routeProgress.inTunnel();

    Is this adding a duplicated behavior or making the API more friendly? Thoughts @danesfeder @devotaaabel?

In order to keep this as simple as possible I went ahead and removed the TunnelListener option altogether. That means, less confusion to clients and less complexity on our side - avoiding any tech debt that this might cause.

I've edited OP to reflect this.

cc @danesfeder @devotaaabel

[danesfeder]

@Guardiola31337 this is looking good, but I was wondering, would it be a good idea to contain all of the client logic needed for setting up night mode in a public class that they may use? Just a thought, I think it would make developers' lives a lot easier if we included something like this that they could use in their Activity or Fragment

[danesfeder]

Does setting this before the Activity is destroyed still allow it to be considered on re-creation?

[Guardiola31337]

Yes it does. Mainly because this is "per app" and in the test app closing any activity redirects you to the MainActivity i.e. the night mode is kept if you reopen the Activity.

[Guardiola31337]

@danesfeder

would it be a good idea to contain all of the client logic needed for setting up night mode in a public class that they may use? Just a thought, I think it would make developers' lives a lot easier if we included something like this that they could use in their Activity or Fragment

IMO If you're referring to extracting the AppCompatDelegate.setDefaultNightMode and the SharedPreferences related code, these are Android implementation details so I don't see a great benefit of exposing from our side. In any case, let me know what you'd include in that convenience class and we can discuss further.

[Guardiola31337]

@danesfeder I followed up on all your comments / concerns / questions. Ready for another round 👀

[danesfeder]

@Guardiola31337 some minor cleanup / comments - this is looking good, thanks for addressing my questions.

[danesfeder]

This chunk of logic can be extracted into a private method. Maybe we can think of better naming for isInTunnel vs. inTunnel - it's a little confusing to determine which variable is coming from where.

[danesfeder]

For readability when the Fragment is being created, this can be extracted into a private method

[danesfeder]

I like the variable naming here - if possible, let's us the same naming in RerouteActivity

[Guardiola31337]

@danesfeder this is updated and ready for another round 👀

[danesfeder]

@Guardiola31337 looks good, thanks for addressing the feedback