[WIP] Add network interceptor and listener for tile download progress #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
force-pushed
the
dan-network-listener
branch
from
1a2c8c6 to
f4da5f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
============================================
- Coverage 35.04% 34.96% -0.09%
Complexity 1060 1060
============================================
Files 261 263 +2
Lines 8848 8870 +22
Branches 667 669 +2
============================================
Hits 3101 3101
- Misses 5475 5497 +22
Partials 272 272 |
andrlee
reviewed
Apr 23, 2019
| } | ||
|
|
||
| @Override | ||
| public Response intercept(@NonNull Chain chain) throws IOException { |
Contributor
There was a problem hiding this comment.
Do we care about RequestBody#contentLength()?
andrlee
reviewed
Apr 23, 2019
| private BufferedSource bufferedSource; | ||
|
|
||
| NetworkResponseBody(ResponseBody responseBody, NetworkProgressListener listener) { | ||
| this.responseBody = responseBody; |
Contributor
There was a problem hiding this comment.
responseBody can be null here..
Contributor
|
#1741 was closed as Offline feature is being re-implemented. Let's make sure the new version includes support for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1741
This PR adds a
NetworkProgressListenerthat will allow us to get progress of a TAR (or any) API request.This is currently blocked upstream by the TAR download API not returning
content-length, so we aren't able to do the math for current progress of the download. Once the lands, we will also need to addInterceptorsupport for theMapboxRouteTilesso we can add the interceptor itself for the network request.TODO:
Interceptorsupportcontent-lengthis being providedcc @kevinkreiser @akitchen