Direction API to Navigation models mappers #2313
Conversation
RingerJK
requested review from
Guardiola31337,
Lebedinsky,
LukasPaczos and
korshaknn
| .baseUrl(baseUrl) | ||
| .alternatives(alternatives) | ||
| .annotations(annotations) | ||
| .approaches(approaches)!! |
There was a problem hiding this comment.
We should fix (remove @Nullable) annotations in mapbox-java e.g. https://github.com/mapbox/mapbox-java/blob/9bd6158292374fc6dd5f7eba33e7586ca1d76177/services-directions/src/main/java/com/mapbox/api/directions/v5/models/RouteOptions.java#L568 Builder cannot be null to avoid unnecessary !!. The same thing happens with another methods below.
There was a problem hiding this comment.
should we make it self or create a ticket for Direction API team? what is algorithm for it?
There was a problem hiding this comment.
Yeah feel free to cut a PR in mapbox-java fixing this (should be a pretty straightforward one 😛). We're in charge of maintaining the nav-related services, the Directions API team does know nothing about these wrappers 😅
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Please cut a PR for https://github.com/mapbox/mapbox-navigation-android/pull/2313/files#r357859760 so we don't forget 🙏
|
@Guardiola31337 just created 😃 |
RingerJK
deleted the
kyv-onboard-router-direction-api--nav-models-mappers-
branch
3 participants
Description
Direction API models map to Navigation SDK's
bug,feature,new API(s),SEMVER, etc.)Goal
Please describe the PR goals. Just the stuff needed to implement the fix / feature and a simple rationale. It could contain many check points if needed
Implementation
Please include all the relevant things implemented and also rationale, clarifications / disclaimers etc. related to the approach used. It could be as self code companion comments
Screenshots or Gifs
Please include all the media files to give some context about what's being implemented or fixed. It's not mandatory to upload screenshots or gifs, but for most of the cases it becomes really handy to get into the scope of the feature / bug being fixed and also it's REALLY useful for UI related PRs
Testing
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PR