Skip to content

Conversation

@kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Jan 9, 2020

Description

In mapbox-java 5.0.0, added the ability to hook up a network interceptor. This will allow us to debug the directions api without making code changes. http://facebook.github.io/stetho/

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Add the ability to debug the api without new code changes. The immediate need to help debug junction view routes.

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #2354 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2354   +/-   ##
=========================================
  Coverage     32.77%   32.77%           
  Complexity      624      624           
=========================================
  Files           143      143           
  Lines          5547     5547           
  Branches        427      427           
=========================================
  Hits           1818     1818           
  Misses         3533     3533           
  Partials        196      196

@kmadsen kmadsen merged commit 75df654 into master Jan 9, 2020
@kmadsen kmadsen deleted the kyle/add-network-interceptor branch April 7, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants