Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

Description

Removes libnavigator unnecessary liblogger and libnavigation-util dependencies

Regression from #2300 (probably from rebasing 😬)

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Avoid building issues as liblogger is not published already

Implementation

Remove implementation(project(':liblogger')) and implementation project(':libnavigation-util') from libnavigator's build.gradle

Testing

Please describe the manual tests that you ran to verify your changes

  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@Guardiola31337 Guardiola31337 merged commit bb44b88 into master Jan 13, 2020
@Guardiola31337 Guardiola31337 deleted the pg-libnavigator-unnecessary-deps branch January 13, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants