Skip to content

Conversation

@langsmith
Copy link
Contributor

@langsmith langsmith commented Apr 20, 2020

<changelog>Added a 1.0.0 test app activity to show Maps SDK + Nav SDK only combo.</changelog>

Description

Adds a new test app example to show how only the Navigation SDK can be used with the Maps SDK.

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

To show how the 1.0.0 Navigation SDK can be purely combined with the Maps SDK, with no usage of the 1.0.0 Navigation UI SDK. The test app's BasicNavigationActivity is definitely basic, but it still uses NavigationMapboxMap, which is a part of the Navigation UI SDK. Many other examples use NavigationMapboxMap.

Implementation

The example added in this pr uses the:

  • Maps SDK's MapboxMap
  • LocationComponent to show the device location
  • Navigation SDK to request a route from the device location to wherever the map is long clicked
  • Maps SDK to show the Navigation SDK's route via a gradient styled Maps SDK LineLayer

Screenshots or Gifs

ezgif com-resize (1)

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • [] I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@langsmith langsmith added test app Core Work related to core navigation and integrations. labels Apr 20, 2020
@langsmith langsmith self-assigned this Apr 20, 2020
@langsmith langsmith changed the title Adding examples test app activity to show Maps SDK + Nav SDK only combo Added an examples test app activity to show Maps SDK + Nav SDK only combo Apr 20, 2020
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comments @langsmith

@langsmith langsmith force-pushed the ls-adding-pure-basic-nav-sdk-test-app-example branch from b8829cb to 30f9d1b Compare April 21, 2020 15:00
@langsmith langsmith force-pushed the ls-adding-pure-basic-nav-sdk-test-app-example branch from 30f9d1b to 04d6c06 Compare April 21, 2020 17:09
@langsmith langsmith force-pushed the ls-adding-pure-basic-nav-sdk-test-app-example branch from 04d6c06 to 0dee834 Compare April 21, 2020 17:11
@langsmith langsmith merged commit 6a230ff into master Apr 21, 2020
@langsmith langsmith deleted the ls-adding-pure-basic-nav-sdk-test-app-example branch April 21, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Work related to core navigation and integrations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants