Skip to content

Conversation

@kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Apr 21, 2020

Description

Looks like this is suddenly blocking PRs #2774

ReplayHistoryMapperTest.kt: (5, 24): 'Assert' is deprecated. Deprecated in Java
  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@Guardiola31337
Copy link
Contributor

Some of these fixes were addressed in #2811 @kmadsen

@Guardiola31337
Copy link
Contributor

Looking at this found that UI 1.0 SDK InstructionListPresenterTest is mostly commented out 🤔 Could you take a look at these tests @abhishek1508 when you have a chance?

@kmadsen
Copy link
Contributor Author

kmadsen commented Apr 21, 2020

Some of these fixes were addressed in #2811 @ kmadsen

oh nice! yeah just looked, and we can still do this one cause the history player needs that 'delta' update

@kmadsen kmadsen merged commit bb874d6 into master Apr 21, 2020
@kmadsen kmadsen deleted the km-use-org-junit branch April 21, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants