Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
runtimeOnlymapboxLoggerdependency tolibnavigation-coreand remove unnecessarymapboxCommondependency fromlibnavigatorRegression from #2774
bug,feature,new API(s),SEMVER, etc.)Goal
mapboxLoggerpreventing the app to crash (trying to instantiateLoggerinMapboxNavigationat initialization) if the dependency is not explicitly addedImplementation
runtimeOnly dependenciesList.mapboxLoggertolibnavigation-corebuild.gradle's fileimplementation dependenciesList.mapboxCommonfromlibnavigatorbuild.gradle's fileTesting
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRcc @Lebedinsky @LukasPaczos