Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

Description

Add runtimeOnly mapboxLogger dependency to libnavigation-core and remove unnecessary mapboxCommon dependency from libnavigator

Regression from #2774

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

  • Inject the default mapboxLogger preventing the app to crash (trying to instantiate Logger in MapboxNavigation at initialization) if the dependency is not explicitly added
  • Cleanup

Implementation

  • Add runtimeOnly dependenciesList.mapboxLogger to libnavigation-core build.gradle's file
  • Remove implementation dependenciesList.mapboxCommon from libnavigator build.gradle's file

Testing

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

cc @Lebedinsky @LukasPaczos

@Guardiola31337 Guardiola31337 added bug Defect to be fixed. ✓ ready for review Core Work related to core navigation and integrations. labels Apr 22, 2020
@Guardiola31337 Guardiola31337 added this to the v1.0.0 milestone Apr 22, 2020
@Guardiola31337 Guardiola31337 requested review from a team, Lebedinsky and LukasPaczos April 22, 2020 18:18
@Guardiola31337 Guardiola31337 self-assigned this Apr 22, 2020
…nnecessary common dependency from libnavigator
@codecov-io
Copy link

Codecov Report

Merging #2829 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2829   +/-   ##
=========================================
  Coverage     35.00%   35.00%           
  Complexity     2107     2107           
=========================================
  Files           541      541           
  Lines         19389    19389           
  Branches       1833     1833           
=========================================
  Hits           6787     6787           
  Misses        11789    11789           
  Partials        813      813           

@Guardiola31337 Guardiola31337 merged commit bb70134 into master Apr 22, 2020
@Guardiola31337 Guardiola31337 deleted the pg-logger-tailwork branch April 22, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Defect to be fixed. Core Work related to core navigation and integrations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants