Remove unnecessary NN Proguard rules #2843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2663
Removes unnecessary NN Proguard rules as they were added downstream
Workarounds
Loggerminification regression from #2774 👀 mapbox/mapbox-base-android#41bug,feature,new API(s),SEMVER, etc.)Goal
Clean up
libnavigator/proguard-rules.pronot necessary anymore as NN11.0.1already adds themImplementation
Remove
from
libnavigator/proguard-rules.proAdds
to
libnavigation-core/proguard-rules.proTesting
examplestest app withminifyEnabled trueSNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRcc @RingerJK