Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Apr 27, 2020

Description

Fixes #2663

Removes unnecessary NN Proguard rules as they were added downstream
Workarounds Logger minification regression from #2774 👀 mapbox/mapbox-base-android#41

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Clean up libnavigator/proguard-rules.pro not necessary anymore as NN 11.0.1 already adds them

Implementation

Remove

-keep class com.mapbox.navigator.** { *; }	
-keep class com.mapbox.bindgen.** { *; }

from libnavigator/proguard-rules.pro

Adds

-keep class com.mapbox.common.logger.MapboxLogger {*;}

to libnavigation-core/proguard-rules.pro

Testing

  • I have tested the examples test app with minifyEnabled true
  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

cc @RingerJK

@Guardiola31337 Guardiola31337 added ✓ ready for review Core Work related to core navigation and integrations. labels Apr 27, 2020
@Guardiola31337 Guardiola31337 added this to the v1.0.0 milestone Apr 27, 2020
@Guardiola31337 Guardiola31337 requested a review from a team April 27, 2020 20:56
@Guardiola31337 Guardiola31337 self-assigned this Apr 27, 2020
@Guardiola31337 Guardiola31337 merged commit 35b23f2 into master Apr 27, 2020
@Guardiola31337 Guardiola31337 deleted the pg-remove-nn-proguard-rules branch April 27, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Work related to core navigation and integrations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary NN Proguard rules

2 participants