Remove ArrivalObserver default implementations #2929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
ArrivalObserverdefault implementationsbug,feature,new API(s),SEMVER, etc.)Goal
ArrivalObserveris currently aninterfacewith default implementations foronStopArrivalandonRouteArrival, so because we're supporting Java 7 (as of now 😁), it'll be unnecessarily converted to anabstractclass on the Java side. The idea behind this was that as a client you don't need to override both if you don’t want to e.g.Only in Kolin though because in Java 7 you'd be forced to implement both. Interface segregation principle is another option to fix this.
We can revisit and bring this back when we support Java 8 (hopefully soon 😅).
Implementation
Remove default implementations (
{}) fromonStopArrivalandonRouteArrival(ArrivalObserver)Testing
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRcc @kmadsen @abhishek1508 @LukasPaczos @langsmith