-
Notifications
You must be signed in to change notification settings - Fork 319
Fixing examples test app LocationComponent race condition
#2947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is this needed by any other examples? |
| } | ||
|
|
||
| override fun onMapReady(mapboxMap: MapboxMap) { | ||
| this.mapboxMap = mapboxMap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some crashes are exchanged with no-op bugs?
That's definitely the reason of the crash. I think it might be easier to understand the fix if Line 294 in 462a94e
|
sounds good, changed the fix and verified it works! |
no, I checked our other examples. |
examples test app LocationComponent race condition
examples/src/main/java/com/mapbox/navigation/examples/core/FasterRouteActivity.kt
Show resolved
Hide resolved
|
Above the |
Description
Fix #2942
The locationComponent is initialized until
navigationMapboxMapbeen created. So not assignmapboxMapvariable until style is loaded and everything is set up.bug,feature,new API(s),SEMVER, etc.)Testing
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PR