Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

Description

Ship with Java 8 bytecode

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Unblock us from taking advantage of some Java 8 language features #2787 (comment)

Worth mentioning that currently mapbox-java adds it implicitly from Retrofit mapbox/mapbox-java#1127 https://github.com/square/retrofit/blob/master/CHANGELOG.md#version-270-2019-12-09 https://cashapp.github.io/2019-02-05/okhttp-3-13-requires-android-5 Refs. mapbox/mapbox-java#1095 mapbox/mapbox-java#1127 and #2684

Also added recently to the UI SDK

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

Implementation

Add

compileOptions {
        sourceCompatibility = JavaVersion.VERSION_1_8
        targetCompatibility = JavaVersion.VERSION_1_8
}

to all modules and

plugins.withId('org.jetbrains.kotlin.jvm') {
  compileKotlin {
    kotlinOptions {
      jvmTarget = "1.8"
    }
  }
}

to root's build.gradle file under subprojects.

Testing

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

cc @mapbox/navigation-android

@Guardiola31337 Guardiola31337 added the Core Work related to core navigation and integrations. label May 20, 2020
@Guardiola31337 Guardiola31337 added this to the v1.0.0 milestone May 20, 2020
@Guardiola31337 Guardiola31337 requested a review from a team May 20, 2020 00:25
@Guardiola31337 Guardiola31337 self-assigned this May 20, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #3003 into master will decrease coverage by 0.00%.
The diff coverage is 12.50%.

@@             Coverage Diff              @@
##             master    #3003      +/-   ##
============================================
- Coverage     36.78%   36.78%   -0.01%     
  Complexity     2216     2216              
============================================
  Files           554      554              
  Lines         19953    19956       +3     
  Branches       1885     1885              
============================================
  Hits           7340     7340              
- Misses        11776    11779       +3     
  Partials        837      837              

Copy link
Contributor

@kmadsen kmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 🎉 🥳

The future is now! 🎂

@zugaldia
Copy link
Member

image

@Guardiola31337 Guardiola31337 merged commit d02eff9 into master May 20, 2020
@Guardiola31337 Guardiola31337 deleted the pg-java-8 branch May 20, 2020 03:16
@Guardiola31337 Guardiola31337 mentioned this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Work related to core navigation and integrations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants