Skip to content

Conversation

@LukasPaczos
Copy link

@LukasPaczos LukasPaczos commented May 20, 2020

Closes #2844.

@LukasPaczos LukasPaczos requested a review from a team May 20, 2020 12:46
@codecov-commenter
Copy link

Codecov Report

Merging #3006 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3006      +/-   ##
============================================
+ Coverage     36.75%   36.76%   +0.01%     
  Complexity     2216     2216              
============================================
  Files           554      554              
  Lines         19952    19952              
  Branches       1885     1885              
============================================
+ Hits           7333     7336       +3     
+ Misses        11782    11780       -2     
+ Partials        837      836       -1     

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this fixes #2844

Also, could you cleanup the commit history or was intentional?

@LukasPaczos
Copy link
Author

Also, could you cleanup the commit history or was intentional?

This was intentional, technically those are separate changes 🙃

@LukasPaczos LukasPaczos merged commit aacb266 into master May 20, 2020
@LukasPaczos LukasPaczos deleted the lp-bump-android-base-v0.1.0 branch May 20, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary libnavigation-core Proguard rules

3 participants