Skip to content

Conversation

@cafesilencio
Copy link

Description

There was a bug on the maps side that resulted in the route line casing not appearing. See https://github.com/mapbox/mapbox-gl-native-internal/issues/268

As a work around for a maps issue not drawing the casing for the route line when they share the same geoJson source, this PR creates separate sources so the the casing line will appear.

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Implementation

Screenshots or Gifs

Testing

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR
  • We might need to update / push api/current.txt files after running $> make core-update-api (Core) / $> make ui-update-api (UI) if there are changes / errors we're 🆗 with (e.g. AddedMethod changes are marked as errors but don't break SemVer) 🚀 If there are SemVer breaking changes add the SEMVER label. See Metalava docs

@cafesilencio cafesilencio requested a review from a team August 19, 2020 18:04
@cafesilencio cafesilencio added the ⚠️ DO NOT MERGE PR should not be merged! label Aug 19, 2020
@cafesilencio cafesilencio force-pushed the sb-route-line-separate-geojson-sources branch from 7c1b00e to 825ef25 Compare August 19, 2020 18:31
@cafesilencio cafesilencio added ⚠️ DO NOT MERGE PR should not be merged! and removed ⚠️ DO NOT MERGE PR should not be merged! labels Aug 19, 2020
@cafesilencio cafesilencio force-pushed the sb-route-line-separate-geojson-sources branch from 825ef25 to 6eb2370 Compare August 25, 2020 17:18
@cafesilencio cafesilencio force-pushed the sb-route-line-separate-geojson-sources branch from 6eb2370 to c9cce58 Compare August 26, 2020 15:45
@LukasPaczos LukasPaczos added UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. and removed ⚠️ DO NOT MERGE PR should not be merged! labels Aug 26, 2020
@LukasPaczos LukasPaczos added this to the v1.0.0 milestone Aug 26, 2020
@cafesilencio cafesilencio merged commit 0138c08 into master Aug 26, 2020
@cafesilencio cafesilencio deleted the sb-route-line-separate-geojson-sources branch August 26, 2020 16:20
@LukasPaczos
Copy link

@cafesilencio whenever you can, could go ahead and revert this change on master? 😁 We are depending on the Maps SDK 9.4.x now, so we shouldn't need this workaround anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants