Merge onboard, offboard and hybrid routers #3498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates all router modules into one. This removes the granular modularity of onboard and offboard router modules and leaves only one routing engine implementation that encapsulates all of the hybrid logic. This opens the door for Mapbox to improve this logic in the future by centralizing it in a native codebase available for all platforms which wouldn't be possible with onboard and offboard routers being modular as well.
The default, hybrid router is still modular by excluding its dependency:
and providing a custom implementation annotated with:
This PR also updates the routers package:
and the module name: