Improve replay route when selecting alternatives routes #5586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadsen
commented
Mar 18, 2022
...igation-core/src/main/java/com/mapbox/navigation/core/replay/route/ReplayProgressObserver.kt
Outdated
Show resolved
Hide resolved
kmadsen
force-pushed
the
km-fix-replay-for-route-alternatives
branch
5 times, most recently
from
a596da9 to
c12d2b1
Compare
LukasPaczos
approved these changes
Mar 21, 2022
...igation-core/src/main/java/com/mapbox/navigation/core/replay/route/ReplayProgressObserver.kt
Outdated
Show resolved
Hide resolved
kmadsen
force-pushed
the
km-fix-replay-for-route-alternatives
branch
2 times, most recently
from
98b1b1f to
0134b4a
Compare
kmadsen
changed the title
kmadsen
force-pushed
the
km-fix-replay-for-route-alternatives
branch
from
0134b4a to
d8445e3
Compare
kmadsen
force-pushed
the
km-fix-replay-for-route-alternatives
branch
from
d8445e3 to
ef031ce
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #5419
There has been a long outstanding issue. When replaying a route with alternatives, the replayer will reset to the beginning when an alternative is selected.
This pull request looks is fixing that.
Screenshots or Gifs
replay-alternatives.mp4