[Android Auto] Remove MapboxNavigation from RoutePreviewCarContext
#6226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadsen
added
the
Android Auto
15 tasks
Codecov Report
@@ Coverage Diff @@
## main #6226 +/- ##
=========================================
Coverage 68.75% 68.75%
Complexity 4311 4311
=========================================
Files 649 649
Lines 26022 26022
Branches 3055 3055
=========================================
Hits 17891 17891
Misses 6971 6971
Partials 1160 1160 |
Zayankovsky
approved these changes
Aug 25, 2022
| carRoutesProvider.navigationRoutes.value | ||
| ) | ||
| MapboxCarApp.updateCarAppState(ActiveGuidanceState) | ||
| MapboxNavigationApp.current()?.let { mapboxNavigation -> |
Contributor
There was a problem hiding this comment.
Looks like it is important to have mapboxNavigation here, should we use !! instead? Or at least log a warning.
Contributor
Author
There was a problem hiding this comment.
yeah.. thinking about this a bit and going with !!. Going to list a couple examples where a developer could create the crash. In particular, this crash could only happen because of 3. It is a small window of a crash, but we could potentially cure the 3 case with a reset function 🤔.
- If you
current()!!before thesetup
MapboxNavigationApp.current()!!.setNavigationRoutes(emptyList())
MapboxNavigationApp.setup(..)- If you
current()!!before theattachlifecycleonCreateis called
MapboxNavigationApp.attach(..)
MapboxNavigationApp.current()!!.setNavigationRoutes(emptyList())- When you're in the middle of resetting options
val navigationOption = MapboxNavigationApp.current()!!.navigationOptions
MapboxNavigationApp.disable()
MapboxNavigationApp.current()!!.setNavigationRoutes(..)
MapboxNavigationApp.setup(navigationOption)
Contributor
Author
There was a problem hiding this comment.
Will merge here, but I think we should consider adding a ReadOnlyDelegate that makes it so current()!! is not a common practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing #6141
CarSpeedLimitRenderertoMapboxNavigationAppCarRoutePreviewScreencan useMapboxNavigationApp.current()since it has single shot actionsGeoDeeplinkNavigateActioncan useMapboxNavigationApp.current()since it has single shot actionsSkipping changelog because there is are no public api changes here.
The remaining migrations are a bit more ambiguous, this classes were some low hanging fruit.