-
Notifications
You must be signed in to change notification settings - Fork 319
[Drop-In UI] Move fetchRouteIfNeeded to RoutePreviewStateController:
#6638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tomaszrybakiewicz
merged 2 commits into
main
from
NAVAND-506_tr-drop-in_move_fetch_route_if_needed2
Jan 5, 2023
Merged
[Drop-In UI] Move fetchRouteIfNeeded to RoutePreviewStateController:
#6638
tomaszrybakiewicz
merged 2 commits into
main
from
NAVAND-506_tr-drop-in_move_fetch_route_if_needed2
Jan 5, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6638 +/- ##
============================================
+ Coverage 72.50% 72.61% +0.10%
- Complexity 5550 5554 +4
============================================
Files 779 780 +1
Lines 30067 30068 +1
Branches 3548 3550 +2
============================================
+ Hits 21801 21833 +32
+ Misses 6841 6807 -34
- Partials 1425 1428 +3
|
abhishek1508
reviewed
Jan 3, 2023
...rc/main/java/com/mapbox/navigation/ui/app/internal/controller/RoutePreviewStateController.kt
Show resolved
Hide resolved
...rc/main/java/com/mapbox/navigation/ui/app/internal/controller/RoutePreviewStateController.kt
Show resolved
Hide resolved
...rc/main/java/com/mapbox/navigation/ui/app/internal/controller/RoutePreviewStateController.kt
Show resolved
Hide resolved
...rc/main/java/com/mapbox/navigation/dropin/map/longpress/RoutePreviewLongPressMapComponent.kt
Show resolved
Hide resolved
58dcd7e to
de4a2fa
Compare
abhishek1508
approved these changes
Jan 4, 2023
- Moved RouteOptionsProvider to SharedApp to allow its injection to RoutePreviewStateController. - Introduced FetchRouteAndShowRoutePreview and FeetchRouteAndStartActivenNavigation actions. - Removed fetchRouteAnd** thunk actions (replaced by the above) - Moved fetch route and start preview/active nav. processing to RoutePreviewStateController - Renamed FetchOptions -> FetchRoute action. - Updated RoutePreviewStateController to directly use RouteOptionsProvider to generate necessary RouteOptions for fetch route request. addressing PR review comments
009996a to
c077dc4
Compare
tomaszrybakiewicz
added a commit
that referenced
this pull request
Jan 10, 2023
…r`: (#6638) * Move `fetchRouteIfNeeded` to `RoutePreviewStateController`: - Moved RouteOptionsProvider to SharedApp to allow its injection to RoutePreviewStateController. - Introduced FetchRouteAndShowRoutePreview and FeetchRouteAndStartActivenNavigation actions. - Removed fetchRouteAnd** thunk actions (replaced by the above) - Moved fetch route and start preview/active nav. processing to RoutePreviewStateController - Renamed FetchOptions -> FetchRoute action. - Updated RoutePreviewStateController to directly use RouteOptionsProvider to generate necessary RouteOptions for fetch route request. addressing PR review comments * Unit tests fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
skip changelog
Should not be added into version changelog.
UI
Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NAVAND-506
Description
Changes:
RouteOptionsProvidertoSharedAppto allow its injection toRoutePreviewStateController.RoutePreviewStateControllerto directly useRouteOptionsProviderto generate necessaryRouteOptions.FetchRouteAndShowRoutePreviewandFeetchRouteAndStartActivenNavigationactions.fetchRouteAnd**thunk actions (replaced by the above actions)RoutePreviewStateControllerFetchOptions->FetchRouteaction and removed redundantRouteOptionsfield.