-
Notifications
You must be signed in to change notification settings - Fork 319
[Drop-In UI] Add support for new speed info view to Drop-In #6743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6743 +/- ##
============================================
+ Coverage 72.50% 72.56% +0.06%
+ Complexity 5528 5526 -2
============================================
Files 774 775 +1
Lines 29950 29975 +25
Branches 3540 3525 -15
============================================
+ Hits 21714 21751 +37
+ Misses 6814 6812 -2
+ Partials 1422 1412 -10
|
58e3ee5 to
99aff8b
Compare
57e199a to
afde9e5
Compare
...avui-speedlimit/src/main/java/com/mapbox/navigation/ui/speedlimit/internal/SpeedInfoStyle.kt
Show resolved
Hide resolved
dzinad
reviewed
Dec 14, 2022
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewStyleCustomization.kt
Outdated
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewStyleCustomization.kt
Outdated
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewStyleCustomization.kt
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewStyleCustomization.kt
Show resolved
Hide resolved
0cebb50 to
42fdb0d
Compare
dzinad
reviewed
Dec 15, 2022
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewBinderCustomization.kt
Outdated
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewStyleCustomization.kt
Show resolved
Hide resolved
1a30038 to
e0d8ffb
Compare
dzinad
reviewed
Dec 19, 2022
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewBinderCustomization.kt
Outdated
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewStyleCustomization.kt
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewBinderCustomization.kt
Outdated
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewBinderCustomization.kt
Outdated
Show resolved
Hide resolved
...-speedlimit/src/main/java/com/mapbox/navigation/ui/speedlimit/internal/SpeedInfoComponent.kt
Show resolved
Hide resolved
Contributor
e0d8ffb to
9d0ee24
Compare
Contributor
Author
|
@dzinad @Zayankovsky All the comments have been addressed. This is ready for final round of 👀 |
dzinad
approved these changes
Dec 20, 2022
9d0ee24 to
341f645
Compare
341f645 to
cd483f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Adds support to show the new
MapboxSpeedInfoViewto Drop-In UIScreenshots or Gifs
video.mp4