Skip to content

Conversation

@abhishek1508
Copy link
Contributor

@abhishek1508 abhishek1508 commented Dec 13, 2022

Description

Adds support to show the new MapboxSpeedInfoView to Drop-In UI

Screenshots or Gifs

video.mp4

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #6743 (baae604) into main (fffb923) will increase coverage by 0.06%.
The diff coverage is 79.80%.

❗ Current head baae604 differs from pull request most recent head cd483f4. Consider uploading reports for the commit cd483f4 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #6743      +/-   ##
============================================
+ Coverage     72.50%   72.56%   +0.06%     
+ Complexity     5528     5526       -2     
============================================
  Files           774      775       +1     
  Lines         29950    29975      +25     
  Branches       3540     3525      -15     
============================================
+ Hits          21714    21751      +37     
+ Misses         6814     6812       -2     
+ Partials       1422     1412      -10     
Impacted Files Coverage Δ
...apbox/navigation/dropin/ViewBinderCustomization.kt 79.41% <0.00%> (-20.59%) ⬇️
...box/navigation/ui/speedlimit/ComponentInstaller.kt 0.00% <0.00%> (ø)
...tion/ui/speedlimit/internal/SpeedLimitComponent.kt 86.66% <ø> (ø)
...ation/ui/speedlimit/internal/SpeedInfoComponent.kt 97.36% <97.36%> (ø)
...mapbox/navigation/dropin/ViewStyleCustomization.kt 100.00% <100.00%> (ø)
...ion/dropin/navigationview/NavigationViewContext.kt 90.24% <100.00%> (+0.50%) ⬆️
...tion/dropin/navigationview/NavigationViewStyles.kt 100.00% <100.00%> (ø)
...avigation/dropin/speedlimit/SpeedInfoViewBinder.kt 100.00% <100.00%> (ø)
...igation/dropin/speedlimit/SpeedLimitCoordinator.kt 100.00% <100.00%> (ø)
...vigation/dropin/speedlimit/SpeedLimitViewBinder.kt 100.00% <100.00%> (ø)
... and 14 more

@abhishek1508 abhishek1508 force-pushed the ak-NAVAND-#1000-update-speed-limit branch 2 times, most recently from 58e3ee5 to 99aff8b Compare December 13, 2022 23:25
@abhishek1508 abhishek1508 marked this pull request as ready for review December 13, 2022 23:28
@abhishek1508 abhishek1508 force-pushed the ak-NAVAND-#1000-update-speed-limit branch 4 times, most recently from 57e199a to afde9e5 Compare December 14, 2022 01:01
@abhishek1508 abhishek1508 force-pushed the ak-NAVAND-#1000-update-speed-limit branch 4 times, most recently from 0cebb50 to 42fdb0d Compare December 14, 2022 23:18
@abhishek1508 abhishek1508 force-pushed the ak-NAVAND-#1000-update-speed-limit branch 2 times, most recently from 1a30038 to e0d8ffb Compare December 16, 2022 21:39
@Zayankovsky
Copy link
Contributor

This is how the new speed info view looks with a dark theme, is it expected?

@abhishek1508 abhishek1508 force-pushed the ak-NAVAND-#1000-update-speed-limit branch from e0d8ffb to 9d0ee24 Compare December 19, 2022 17:47
@abhishek1508
Copy link
Contributor Author

@dzinad @Zayankovsky All the comments have been addressed. This is ready for final round of 👀

@abhishek1508 abhishek1508 force-pushed the ak-NAVAND-#1000-update-speed-limit branch from 9d0ee24 to 341f645 Compare December 20, 2022 17:25
@abhishek1508 abhishek1508 force-pushed the ak-NAVAND-#1000-update-speed-limit branch from 341f645 to cd483f4 Compare December 20, 2022 17:26
@abhishek1508 abhishek1508 enabled auto-merge (rebase) December 20, 2022 18:09
@abhishek1508 abhishek1508 merged commit 1e4adfc into main Dec 20, 2022
@abhishek1508 abhishek1508 deleted the ak-NAVAND-#1000-update-speed-limit branch December 20, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants