NAVAND-940: fix buildings highlighting #6754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6754 +/- ##
=========================================
Coverage 72.54% 72.54%
- Complexity 5521 5522 +1
=========================================
Files 772 772
Lines 29888 29899 +11
Branches 3531 3533 +2
=========================================
+ Hits 21682 21691 +9
Misses 6793 6793
- Partials 1413 1415 +2
|
RingerJK
reviewed
Dec 16, 2022
libnavigation-base/src/main/java/com/mapbox/navigation/base/internal/extensions/WaypointEx.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/building/BuildingProcessor.kt
Outdated
Show resolved
Hide resolved
Comment on lines
79
to
80
| val prevEVWaypointsCount = legWaypoints.take(legWaypointIndex + 1) | ||
| .count { it.isEVChargingWaypoint() } |
Contributor
There was a problem hiding this comment.
nit
it was hard to get the idea at the first glance. Up to you
Suggested change
| val prevEVWaypointsCount = legWaypoints.take(legWaypointIndex + 1) | |
| .count { it.isEVChargingWaypoint() } | |
| val coordinateIdx = waypoints.map { it.isRequestedWaypoints }.indexOf(waypoints.map {it.isLegWaypoint }[legWaypointIndex]) | |
| return progress.navigationRoute.routeOptions.coordinatesList() | |
| .getOrNull(coordinateIdx) |
Contributor
Author
There was a problem hiding this comment.
I don't want to use indexOf. In case the equality check of waypoints is broken or something. I know it sounds weird but it's less strict than counting the number of "bad" waypoints and subtracting them.
I rewrote it in terms of requested waypoints, nothing EV related remains.
RingerJK
approved these changes
Dec 16, 2022
dzinad
force-pushed
the
NAVAND-940-dd-2
branch
from
c6d5aef to
f551592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.