[copilot] Add Proguard rule to prevent obfuscation of route properties #6762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
Core
nkukday
approved these changes
Dec 19, 2022
Zayankovsky
approved these changes
Dec 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #6762 +/- ##
=========================================
Coverage 72.49% 72.49%
Complexity 5522 5522
=========================================
Files 772 772
Lines 29924 29924
Branches 3535 3535
=========================================
Hits 21694 21694
Misses 6814 6814
Partials 1416 1416 |
Guardiola31337
pushed a commit
that referenced
this pull request
Dec 19, 2022
Guardiola31337
pushed a commit
that referenced
this pull request
Dec 19, 2022
dzinad
reviewed
Dec 20, 2022
| @@ -1,0 +1 @@ | |||
| -keepnames class com.mapbox.api.directions.v5.models.** {*;} | |||
Contributor
There was a problem hiding this comment.
It seems like it would be better to put this line into the consumer file of the original SDK.
Questions:
- Is it possible for Java, not Android?
- Why do you keep only the models package?
- Why do you need to keep that at all?
Maybe it's all described somewhere but I don't see links to any tickets.
Guardiola31337
pushed a commit
that referenced
this pull request
Jan 12, 2023
Guardiola31337
pushed a commit
that referenced
this pull request
Jan 12, 2023
Guardiola31337
pushed a commit
that referenced
this pull request
Jan 12, 2023
Guardiola31337
pushed a commit
that referenced
this pull request
Jan 12, 2023
Guardiola31337
pushed a commit
that referenced
this pull request
Jan 12, 2023
Guardiola31337
pushed a commit
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Proguard rule to prevent obfuscation of
route(DirectionsRoute) propertiescc @ikryvanos