-
Notifications
You must be signed in to change notification settings - Fork 319
[Drop-In] Get notified when clicked on SpeedInfoView #6770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6770 +/- ##
============================================
- Coverage 72.51% 72.50% -0.02%
- Complexity 5541 5546 +5
============================================
Files 777 779 +2
Lines 30039 30060 +21
Branches 3547 3547
============================================
+ Hits 21783 21794 +11
- Misses 6832 6842 +10
Partials 1424 1424
|
Contributor
|
I'm not sure why changelog-verification task thinks it's not a PR but you didn't update the changelog. |
dzinad
approved these changes
Dec 22, 2022
Zayankovsky
reviewed
Dec 22, 2022
...ui-dropin/src/main/java/com/mapbox/navigation/dropin/navigationview/NavigationViewContext.kt
Outdated
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/speedlimit/SpeedInfoBehavior.kt
Outdated
Show resolved
Hide resolved
bf07eed to
f5a1adb
Compare
f5a1adb to
9814236
Compare
Zayankovsky
approved these changes
Jan 3, 2023
Closed
This was referenced Jan 5, 2023
This was referenced Jan 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user clicks on
MapboxSpeedInfoView, the changes will notify the developer about it usingNavigationViewListener#onSpeedInfoClicked(speedInfo: SpeedInfoValue?)