Skip to content

Conversation

@Zayankovsky
Copy link
Contributor

Description

Drop-In UI overrides some of the resources in libnavui-maneuver module, but not all of them, which makes the standalone MapboxManeuerView draw black text on a black background when rendering exit info. This also affects Android Auto, because it uses the same ManeuverViewOptions as the standalone MapboxManeuerView.

@Zayankovsky Zayankovsky added bug Defect to be fixed. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. needs backporting Requires cherry-picking to a currently running release branch labels Dec 22, 2022
@Zayankovsky Zayankovsky self-assigned this Dec 22, 2022
@Zayankovsky Zayankovsky marked this pull request as ready for review December 22, 2022 12:25
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #6774 (02c22f1) into main (8248c1f) will not change coverage.
The diff coverage is n/a.

❗ Current head 02c22f1 differs from pull request most recent head e614789. Consider uploading reports for the commit e614789 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6774   +/-   ##
=========================================
  Coverage     72.51%   72.51%           
  Complexity     5541     5541           
=========================================
  Files           777      777           
  Lines         30039    30039           
  Branches       3547     3547           
=========================================
  Hits          21783    21783           
  Misses         6832     6832           
  Partials       1424     1424           

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @Zayankovsky 🚀

@abhishek1508
Copy link
Contributor

This is the Drop-In UI dark mode

I am running the Custom Navigation View activity from qa-test-app.

@Zayankovsky

@abhishek1508
Copy link
Contributor

This is standalone maneuver view example without Drop-In using dark mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Defect to be fixed. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants