Skip to content

Conversation

@SevaZhukov
Copy link

@SevaZhukov SevaZhukov commented Jan 16, 2023

https://mapbox.atlassian.net/browse/NAVAND-501

Run release-snapshot workflow on publish-snapshot label

@SevaZhukov SevaZhukov requested a review from RingerJK January 16, 2023 15:18
@github-actions
Copy link

Changelog

Features

Bug fixes and improvements

  • Improved NavigationView camera behavior to go back into overview state if routes change during route preview state. #6840

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@github-actions github-actions bot requested a review from dzinad January 16, 2023 15:19
@SevaZhukov SevaZhukov marked this pull request as draft January 17, 2023 07:19
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #6843 (04768c4) into main (1098030) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6843   +/-   ##
=========================================
  Coverage     72.64%   72.64%           
  Complexity     5564     5564           
=========================================
  Files           781      781           
  Lines         30116    30116           
  Branches       3561     3561           
=========================================
  Hits          21878    21878           
  Misses         6810     6810           
  Partials       1428     1428           

@SevaZhukov SevaZhukov marked this pull request as ready for review January 18, 2023 16:09
Copy link
Contributor

@RingerJK RingerJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 👍

Seems that if names somehow are the same the newest snapshot substitute the legacy one.
We must be careful and provide snapshots with unique names. Seems if a name contains a number of jira's ticket it should be enough.

@RingerJK RingerJK requested a review from kmadsen January 18, 2023 17:01
@dzinad
Copy link
Contributor

dzinad commented Jan 19, 2023

Seems that if names somehow are the same the newest snapshot substitute the legacy one.
We must be careful and provide snapshots with unique names. Seems if a name contains a number of jira's ticket it should be enough.

I think it's how it's supposed to be for snapshots. You may want to rewrite them. For example, if you are testing something from a branch, for the second, third and so forth iterations you wouldn't want to think of new version names.

@SevaZhukov SevaZhukov merged commit 96bdcc3 into main Jan 19, 2023
@SevaZhukov SevaZhukov deleted the NAVAND-501 branch January 19, 2023 08:25
@RingerJK
Copy link
Contributor

I think it's how it's supposed to be for snapshots. You may want to rewrite them. For example, if you are testing something from a branch, for the second, third and so forth iterations you wouldn't want to think of new version names.

I'm on the same page, just worrying if coincidentally names of the branch match, and it will lead to version substituting of a snapshot. Let's not worry about it for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants