-
Notifications
You must be signed in to change notification settings - Fork 319
Add a ReplayHistorySession #6855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ChangelogFeatures
val shielded = roadName.shieldedinto: val shielded = roadComponent.shield != null
Bug fixes and improvements
Known issues
|
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Show resolved
Hide resolved
...vigation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistoryMapper.kt
Show resolved
Hide resolved
...igation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistorySession.kt
Outdated
Show resolved
Hide resolved
...igation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistorySession.kt
Outdated
Show resolved
Hide resolved
...igation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistorySession.kt
Show resolved
Hide resolved
489d9e7 to
4d9d25d
Compare
|
Do we need to add functions to |
4d9d25d to
264460d
Compare
Codecov Report
@@ Coverage Diff @@
## main #6855 +/- ##
=========================================
Coverage 72.68% 72.68%
Complexity 5572 5572
=========================================
Files 782 782
Lines 30166 30166
Branches 3562 3562
=========================================
Hits 21926 21926
Misses 6814 6814
Partials 1426 1426 |
7478151 to
59ebc54
Compare
Yeah we do. I'm also thinking we should interact directly with I'm also not positive on what I think the |
74a3e1a to
910ecda
Compare
d955746 to
74eb6d3
Compare
74eb6d3 to
68328c2
Compare
examples/src/main/java/com/mapbox/navigation/examples/core/ReplayHistoryActivity.kt
Outdated
Show resolved
Hide resolved
examples/src/main/java/com/mapbox/navigation/examples/core/ReplayHistoryActivity.kt
Outdated
Show resolved
Hide resolved
...igation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistorySession.kt
Outdated
Show resolved
Hide resolved
...igation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistorySession.kt
Outdated
Show resolved
Hide resolved
68328c2 to
c9b1ec0
Compare
Description
We now have a very simple way to replay routes with
TripSessionStarterandReplayRoutesSession. What we want, is to add the ability to replay history. For this I'm adding a way to enable it through theTripSessionStarterso you can switch between replaying routes, regular active guidance, and replaying history. I'm also adding aReplayHistorySessionso we can isolate the logic for tests and use it for solutions that only need to replay a history file.Unblocking https://mapbox.atlassian.net/browse/NAVAND-804
Examples
Using
MapboxNavigationAppand theMapboxTripStarter.Using
ReplayHistorySessionandMapboxNavigationdirectly.