Skip to content

Conversation

@DzmitryFomchyn
Copy link
Contributor

@DzmitryFomchyn DzmitryFomchyn commented Feb 23, 2024

Description

Backports #7755 to 2.18

…rences (#7755)

* Dynamic telemetry initialisation/deinitialisation based on user preference

* Fix tests

* TODO issue; Changelog

* Fail only in debug mode

* Don't observe telemetry state changes for now

* Address PR comments; Add tests
@DzmitryFomchyn DzmitryFomchyn requested a review from a team as a code owner February 23, 2024 14:50
@github-actions
Copy link

github-actions bot commented Feb 23, 2024

Changelog

Features

Bug fixes and improvements

  • Resolved an issue where a crash could occur if telemetry sending settings were changed after creating MapboxNavigation. [#7757](https://github.com/mapbox/mapbox-navigation-android/pull/7757)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 73.40426% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 74.13%. Comparing base (e33f87a) to head (e0c8467).

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release-v2.18    #7757      +/-   ##
===================================================
+ Coverage            74.10%   74.13%   +0.03%     
- Complexity            6162     6173      +11     
===================================================
  Files                  835      838       +3     
  Lines                33167    33219      +52     
  Branches              3955     3964       +9     
===================================================
+ Hits                 24578    24628      +50     
+ Misses                7055     7049       -6     
- Partials              1534     1542       +8     
Files Coverage Δ
...gation/core/telemetry/MapboxNavigationTelemetry.kt 80.89% <ø> (ø)
...m/mapbox/navigation/core/telemetry/SdkTelemetry.kt 100.00% <100.00%> (ø)
...mapbox/navigation/core/MapboxNavigationProvider.kt 45.00% <77.77%> (-0.46%) ⬇️
...com/mapbox/navigation/utils/internal/Assertions.kt 0.00% <0.00%> (ø)
...ava/com/mapbox/navigation/core/MapboxNavigation.kt 72.00% <76.00%> (+2.14%) ⬆️
...pbox/navigation/core/telemetry/TelemetryWrapper.kt 74.50% <74.50%> (ø)

@DzmitryFomchyn DzmitryFomchyn merged commit 2eb3219 into release-v2.18 Feb 23, 2024
@DzmitryFomchyn DzmitryFomchyn deleted the df-telemetry-fix-2-18 branch February 23, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants