Update translation Strings and add Burmese #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| <!-- Feedback type for Confusing Instruction --> | ||
| <string name="feedback_confusing_instruction">ညြန္ၾကားခ်က္ | ||
| ရႈတ္ေထြးေနသည္</string> |
Contributor
There was a problem hiding this comment.
Why is this in a new line? Could it be a problem?
Contributor
Author
There was a problem hiding this comment.
Yeah I saw that - this is how they were pulled down from Transifex. @1ec5 could this be a possible issue?
Contributor
There was a problem hiding this comment.
At least in the iOS navigation SDK, we intentionally put hard linebreaks in the feedback UI so things wrap better. I don’t know enough about the Android strings XML format to know if it’ll be a problem. My guess would be that it’s OK.
|
|
||
| <!-- Feedback type for Other Map Issue Issue --> | ||
| <string name="feedback_general_issue">အျခား | ||
| ေျမပုံ ျပႆနာ</string> |
Contributor
There was a problem hiding this comment.
Why is this in a new line? Could it be a problem?
1ec5
approved these changes
May 15, 2018
Contributor
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
Remember to update localization.md.
danesfeder
force-pushed
the
dan-lang-update
branch
from
a823d97 to
80c8bb6
Compare
danesfeder
force-pushed
the
dan-lang-update
branch
from
80c8bb6 to
8f8ea32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates new translations added to Transifex and add Burmese language