Resume navigation state based on MapboxNavigation running #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devotaaabel
approved these changes
May 15, 2018
danesfeder
force-pushed
the
dan-camera-night
branch
from
d2b8440 to
e923253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI was getting stuck when initialized in night mode - this is because the Android framework quickly recreates the activity when it 👀 sees it's in night mode so the
Bundle savedInstanceStateis notnull. But, navigation has not begun yet, so navigation was failing to start.This PR now makes the navigation view look at if navigation is running instead of the saved instance state being null - a much more reliable way to resume navigation after rotation.