Skip to content

Reset EventDispatcher in onDestroy #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danesfeder merged 1 commit into from
May 21, 2018
Merged

Reset EventDispatcher in onDestroy #954

danesfeder merged 1 commit into from
May 21, 2018

Conversation

@danesfeder
Copy link
Contributor

@danesfeder danesfeder commented May 18, 2018

@devotaaabel and I were seeing a leak, I believe a regression resulting from #923.

NavigationViewModel was holding the instance of NavigationViewEventDispatcher on rotation.

@danesfeder danesfeder added bug Defect to be fixed. navigation-ui labels May 18, 2018
@danesfeder danesfeder added this to the 0.14.0 milestone May 18, 2018
@danesfeder danesfeder self-assigned this May 18, 2018
@Guardiola31337
Copy link
Contributor

Guardiola31337 commented May 21, 2018

@danesfeder @devotaaabel do you have the leak report by any chance? I'm curious how NavigationViewEventDispatcher could produce a leak if it's holding only callbacks 🤔

@Guardiola31337
Copy link
Contributor

Guardiola31337 commented May 21, 2018

Run into the same leak after launching NavigationActivity > press X button and then > back button to close the test app (no rotation involved) 👀

navigation_activity_leak

@danesfeder
Copy link
Contributor Author

danesfeder commented May 21, 2018

NavigationEventDispatcher survives rotation with MapboxNavigation in the NavigationViewModel and we use the normal NavigationEventDispatcher to push events to NavigationViewEventDispatcher. So the old instance of NavigationViewEventDispatcher was getting event event updates, causing this leak.

Guardiola31337
Guardiola31337 approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @danesfeder @devotaaabel

:shipit:

@danesfeder danesfeder merged commit 5f66e49 into master May 21, 2018
@danesfeder danesfeder deleted the dan-nav-leak branch May 21, 2018 14:24
@danesfeder danesfeder mentioned this pull request May 31, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devotaaabel devotaaabel Awaiting requested review from devotaaabel

1 more reviewer

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danesfeder danesfeder

Labels

bug Defect to be fixed.

Projects

None yet

Milestone

0.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@danesfeder @Guardiola31337