Add List of Milestones to NavigationViewOptions #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
May 28, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Minor related question, not blocking the PR though.
| List<Milestone> milestones = options.milestones(); | ||
| if (milestones != null && !milestones.isEmpty()) { | ||
| for (Milestone milestone : milestones) { | ||
| navigation.addMilestone(milestone); |
Contributor
There was a problem hiding this comment.
Have we ever considered adding an addMilestones(List<Milestone>) API to MapboxNavigation? That way we could use List#addAll for example and remove the for each loop.
Contributor
Author
There was a problem hiding this comment.
@Guardiola31337 this is a great idea - will add, thanks!
danesfeder
force-pushed
the
dan-milestone-view-options
branch
5 times, most recently
from
9a8d48b to
ac9072b
Compare
danesfeder
force-pushed
the
dan-milestone-view-options
branch
from
ac9072b to
a877b2e
Compare
Contributor
Author
|
@Guardiola31337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #947
Allows
Milestones to be added to theNavigationView