Add custom minimum alert distances for Cycling/Walking/Driving #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace RouteControllerMinimumDistanceForMediumAlert and RouteControllerMinimumDistanceForHighAlert with RouteControllerMinimumDistanceForHighAlertDriving, RouteControllerMinimumDistanceForHighAlertCycling, RouteControllerMinimumDistanceForHighAlertWalking RouteControllerMinimumDistanceForMediumAlertDriving, RouteControllerMinimumDistanceForMediumAlertCycling, RouteControllerMinimumDistanceForMediumAlertWalking to allow for different minimum distance per transportation method. - Add RouteControllerMinimumDistanceForMediumAlert(identifier:) and RouteControllerMinimumDistanceForHighAlert(identifier:) to choose which minimum distance is approriate for which MBDirectionsProfileIdentifier type. - Modifiy MapboxNavigation/RouteController and MapboxNavigationUI/RouteVoiceController to use new minimum distance values.
1ec5
reviewed
Mar 21, 2017
MapboxNavigation/Constants.swift
Outdated
| public var RouteControllerMinimumDistanceForMediumAlertWalking: CLLocationDistance = 100 | ||
|
|
||
| public func RouteControllerMinimumDistanceForMediumAlert(identifier: MBDirectionsProfileIdentifier) -> CLLocationDistance { | ||
| if identifier == .automobile || identifier == .automobileAvoidingTraffic { |
Contributor
There was a problem hiding this comment.
Could this be a switch statement?
Contributor
Author
There was a problem hiding this comment.
Originally I thought because MBDirectionsProfileIdentifier is a struct type, switching on it may be a bit weird. But I think it's possible to switch on this. I will submit a new commit.
- Use switch() instead of if else when evaulating RouteControllerMinimumDistanceForMediumAlert and RouteControllerMinimumDistanceForHighAlert.
Contributor
Author
Contributor
|
👍 looks good |
This was referenced Mar 24, 2017
Closed
wishtrip-dev
pushed a commit
to wishtrip-dev/mapbox-navigation-ios
that referenced
this pull request
Feb 28, 2018
Objective-C example application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace RouteControllerMinimumDistanceForMediumAlert and RouteControllerMinimumDistanceForHighAlert with
RouteControllerMinimumDistanceForHighAlertDriving, RouteControllerMinimumDistanceForHighAlertCycling, RouteControllerMinimumDistanceForHighAlertWalking
RouteControllerMinimumDistanceForMediumAlertDriving, RouteControllerMinimumDistanceForMediumAlertCycling, RouteControllerMinimumDistanceForMediumAlertWalking
to allow for different minimum distance per transportation method.
Add RouteControllerMinimumDistanceForMediumAlert(identifier:) and RouteControllerMinimumDistanceForHighAlert(identifier:)
to choose which minimum distance is approriate for which MBDirectionsProfileIdentifier type.
Modifiy MapboxNavigation/RouteController and MapboxNavigationUI/RouteVoiceController to use
new minimum distance values.
@bsudekum @1ec5 @boundsj