Place Picker crashes on Android X

[riastrad]

There is a known issue with the AndroidX migration tool in Android Studio that fails to update the XML for BottomSheetBehavior in projects. (See Stack Overflow discussion.)

Unfortunately our Places Plugin was not spared by this issue and will crash if you use the Place Picker on AndroidX.

Example crash:

2019-04-03 11:26:47.146 16098-16098/com.your.androidapp E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.your.androidapp, PID: 16098
java.lang.IllegalArgumentException: Illegal state argument: 5
at com.google.android.material.bottomsheet.BottomSheetBehavior.startSettlingAnimation(BottomSheetBehavior.java:1059)
at com.google.android.material.bottomsheet.BottomSheetBehavior.startSettlingAnimationPendingLayout(BottomSheetBehavior.java:846)
at com.google.android.material.bottomsheet.BottomSheetBehavior.setState(BottomSheetBehavior.java:825)
at com.mapbox.mapboxsdk.plugins.places.picker.ui.CurrentPlaceSelectionBottomSheet.toggleBottomSheet(CurrentPlaceSelectionBottomSheet.java:80)
at com.mapbox.mapboxsdk.plugins.places.picker.ui.CurrentPlaceSelectionBottomSheet.setPlaceDetails(CurrentPlaceSelectionBottomSheet.java:55)
at com.mapbox.mapboxsdk.plugins.places.picker.ui.PlacePickerActivity.onCameraIdle(PlacePickerActivity.java:158)
at com.mapbox.mapboxsdk.maps.CameraChangeDispatcher.executeOnCameraIdle(CameraChangeDispatcher.java:140)
at com.mapbox.mapboxsdk.maps.CameraChangeDispatcher.access$300(CameraChangeDispatcher.java:21)
at com.mapbox.mapboxsdk.maps.CameraChangeDispatcher$CameraChangeHandler.handleMessage(CameraChangeDispatcher.java:169)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:163)
at android.app.ActivityThread.main(ActivityThread.java:6238)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:794)
  

Fortunately this should be an easy fix since we only need to modify this line of our XML:

mapbox-plugins-android/plugin-places/src/main/res/layout/mapbox_view_bottom_sheet_container.xml

Line 50 in 67efb48

app:layout_behavior="android.support.design.widget.BottomSheetBehavior">

cc: @mapbox/maps-android

[LukasPaczos]

Great find @riastrad! Since we are planning the release soon, I'm going to go ahead and cut the PR.

[LukasPaczos]

Unfortunately, I don't think this is going to as straightforward.

app:layout_behavior="com.google.android.material.bottomsheet.BottomSheetBehavior"

is not available if AndroidX is not used. From the SO post I understand that the toolchain is missing this mapping, so the Jettifier fails to auto-migrate our library. I'm not sure if this is going to be actionable for us in this case, until we migrate the repo to AndroidX.

[lazydoozer]

@LukasPaczos Is there any workaround in the interim until that migration to AndroidX? Is there a timeline for the migration?

I was hoping to use some of the mapbox plugins in a application that has already been migrated to AndroidX

[LukasPaczos]

@lazydoozer no workarounds that I'm aware of. We're exploring upgrading some plugins to AndroidX and Places might be a good candidate. No concrete timeline though.

[Johnyoat]

Any progress with this issue please?

[langsmith]

#1100 will resolve this