Skip to content

Fix scalebar not show correctly when pixelRatio is set. #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chaoba merged 1 commit into from
Mar 10, 2020
Merged

Fix scalebar not show correctly when pixelRatio is set. #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin-scalebar/src/main/java/com/mapbox/pluginscalebar/ScaleBarPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public void setEnabled(boolean enabled) {
private void invalidateScaleBar() {
CameraPosition cameraPosition = mapboxMap.getCameraPosition();
scaleBarWidget.setDistancePerPixel((projection.getMetersPerPixelAtLatitude(cameraPosition.target.getLatitude()))
/ mapView.getContext().getResources().getDisplayMetrics().density);
/ mapView.getPixelRatio());
}

private void addCameraListeners() {
Expand Down
1 change: 1 addition & 0 deletions plugin-scalebar/src/test/java/com/mapbox/pluginscalebar/ScaleBarPluginTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class ScaleBarPluginTest {
every { mapboxMap.cameraPosition } returns CameraPosition.DEFAULT
every { scaleBarOptions.build() } returns scaleBarWidget
every { mapView.context} returns context
every { mapView.pixelRatio } returns 2f
every { context.resources} returns resources
every { resources.displayMetrics} returns displayMetrics
}
Expand Down