Added .baseUrl() to Places Plugin's PlaceOptions builder #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI tests aren't running because of known Github 🦄issues right now |
langsmith
force-pushed
the
ls-adding-base-url-setting-to-places-plugin
branch
from
f6be31e to
2bffd9c
Compare
langsmith
added
the
ready for review
zugaldia
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds
.baseUrl()to the Places Plugin'sPlaceOptionsbuilder.Using https://www.mapbox.com/atlas is a good example of when a user might want to make geocoding calls to a different base URL than the default Mapbox one.