Skip to content

[annotation] Consume event when drag end to prevent click event #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasPaczos merged 1 commit into from
Jul 22, 2020
Merged

[annotation] Consume event when drag end to prevent click event #1141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .../src/main/java/com/mapbox/mapboxsdk/plugins/annotation/DraggableAnnotationController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ public DraggableAnnotationController(MapView mapView, MapboxMap mapboxMap,
mapView.setOnTouchListener(new View.OnTouchListener() {
@Override
public boolean onTouch(View v, MotionEvent event) {
Annotation oldAnnotation = draggedAnnotation;
androidGesturesManager.onTouchEvent(event);
// if drag is started, don't pass motion events further
return draggedAnnotation != null;
// if drag is started or drag is finished, don't pass motion events further
return draggedAnnotation != null || oldAnnotation != draggedAnnotation;
}
});
}
Expand Down