CP 1125 #1147
Merged
CP 1125 #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nager_singleton
tobrun
approved these changes
Jul 29, 2020
pengdev
approved these changes
Jul 29, 2020
tarigo
approved these changes
Jul 29, 2020
|
When can we expect this in production? |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks #1125 to let the bots run. Huge thanks for the contribution @Ph0tonic!
On top of the original PR I cleaned up the static references in the draggable controller and updated code generation scripts.
Closes #863. I'm gonna squash before merging.