Add sdk-registry config #1177
Merged
Add sdk-registry config #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengdev
reviewed
Mar 22, 2021
pengdev
reviewed
Mar 22, 2021
Chaoba
force-pushed
the
kl-registry
branch
3 times, most recently
from
ff62b64 to
6fd898e
Compare
pengdev
reviewed
Mar 23, 2021
pengdev
reviewed
Mar 23, 2021
pengdev
reviewed
Mar 23, 2021
pengdev
reviewed
Mar 23, 2021
| release: | ||
| docker: | ||
| - image: mbgl/android-ndk-r19:8e91a7ebab | ||
| - image: mbgl/android-ndk-r21:769c31f1d8 |
Contributor
Author
There was a problem hiding this comment.
It's align with maps sdk v9
pengdev
reviewed
Mar 23, 2021
| POM_NAME=Mapbox Maps SDK for Android KTX | ||
| POM_DESCRIPTION=A set of Kotlin extensions for the Mapbox Maps SDK for Android. | ||
| POM_PACKAGING=aar | ||
| REGISTRY_SDK_NAME=mapbox-android-ktx |
Member
There was a problem hiding this comment.
is this the correct name? looks different than the other names.
Contributor
Author
There was a problem hiding this comment.
It seems we have never released this before. Please correct me if I'm wrong. @tobrun
pengdev
approved these changes
Mar 23, 2021
Member
pengdev
left a comment
pengdev
left a comment
There was a problem hiding this comment.
LGTM with 2 questions, please create a ticket to track the tail work of enabling release automation through CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.